Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated command with environment file #6202

Closed
wants to merge 1 commit into from
Closed

chore: replace deprecated command with environment file #6202

wants to merge 1 commit into from

Conversation

jongwooo
Copy link

Description

Update .github/workflows/release.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=sha::$(git rev-parse HEAD)"
echo "::set-output name=result::$result"

TO-BE

echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
echo "result=$result" >> $GITHUB_OUTPUT

References

Closes #6201

@jongwooo jongwooo requested a review from a team as a code owner February 25, 2023 15:31
@jongwooo jongwooo requested review from fritzy and removed request for a team February 25, 2023 15:31
@lukekarrys
Copy link
Contributor

Thanks for the PR. We manage these workflows via @npmcli/template-oss automatically which just landed this fix as well, so I'm going to close this PR.

@lukekarrys lukekarrys closed this Mar 8, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch March 8, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy Awaiting requested review from fritzy fritzy is a code owner automatically assigned from npm/cli-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SUGGESTION] Replace deprecated set-output command with environment file
2 participants
@jongwooo @lukekarrys